Document $, !, @ and # in symbol names #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
May 4, 2017
martin-cs
approved these changes
May 4, 2017
src/util/ssa_expr.cpp
Outdated
| os << '@' << l1; | ||
| l1_object_os << '@' << l1; | ||
| } | ||
|
|
||
| if(!l2.empty()) | ||
| { | ||
| // distinguish assignments to the same variable |
There was a problem hiding this comment.
s/distinguish/Distinguish/ for consistency
Also I might phrase this slightly differently as this is not just assignments (instructions in the program) but SSA steps. One assignment can give many SSA steps, for example if it is in a loop.
"Distinguish SSA steps for the same variable" maybe?
owen-mc-diffblue
force-pushed
the
doc/symbol_name_separators
branch
from
01c5b2d to
f19a3e7
Compare
owen-mc-diffblue
force-pushed
the
doc/symbol_name_separators
branch
from
f19a3e7 to
082e95e
Compare
Document what symbol name suffices beginning with $, !, @ and # mean, at the points in the code where they are created.
owen-mc-diffblue
force-pushed
the
doc/symbol_name_separators
branch
from
082e95e to
0edafab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document what symbol name suffices beginning with $, !, @ and # mean,
at the points in the code where they are created.